OT: I just had my first ever Pull Request accepted :)

OT: I just had my first ever Pull Request accepted :)
0

#1

I downloaded a small widget for monitoring my bandwidth quota from my ISP on Ubuntu and it wasn’t working.

Since I got it from GitHub I decided to crack it open and see if I could fix it.

After a little poking around I made what I thought would be the correct changes and verified that it now worked as expected.

Then I took the plunge and sent an unsolicited Pull Request with my fix and it was accepted :slight_smile:

Pretty pleased with myself right now!

It was only a three line fix, but I’m happy because I knew which screw to turn


#2

Congratulations :smile: i hope i make my first pull request soon :pray:


#3

My first PR that got accepted is changing “an generic” to “a generic” in a chapter in YDKJS :slight_smile:.


#5

Congrats! It’s a good feeling!

For anyone looking to make their first PR, the FCC repo is a very forgiving environment to learn. Setup is a little involved, but once you get that done, look for the first-timers only yeah on the issues page and have at it. Just make sure to follow the rules for naming branches and whatnot.


#6

Nice! That’s awesome!


#7

Good job and congrats!