diomed
August 14, 2017, 1:40pm
1
2 Likes
Aah, if no one has done it by tomorrow, I’m totally taking Japan.
1 Like
As was posted, there are tons of sites that list all these holidays so you can just grab them from there should be rather quick.
diomed
August 14, 2017, 2:01pm
5
yes, but one has to do it in his/her own native language.
I’ll try to add for the country Nigeria soonest. Wish me luck!
1 Like
Waxaz
August 14, 2017, 3:22pm
7
I’ll take Russia. Hope, it help. Cheers!
1 Like
Waxaz
August 15, 2017, 12:00am
8
Hey. I’m done with Russia, but I can’t push it to your Git repo. Could you pls give me access? My github profile is https://github.com/Vasil11
@diomed I think I have the same problem with @Waxaz ; I have tried committing to the project yesterday but I have not seen changes so far. Could you please check and let me know if I didn’t do something correctly please?
My github profile is https://github.com/e-zidaf and I committed and made the push via SourceTree
NB: Willing to learn Rookie here.
diomed
August 15, 2017, 9:31am
10
I don’t see you forked this at all, it’s not in your list of repositories anywhere.
diomed
August 15, 2017, 9:34am
11
this looks good. did u make a pull request?
go to pull requests - and hit green button New pull request so u could send it to main repo,
from which you’ve forked it from.
Thanks.
I just completed the pull request and I hope this works. Kindly check again and let me know if or if not everything looks good.
Regards.
diomed
August 15, 2017, 9:49am
13
your pull request should be visible here: https://github.com/kodie/moment-holiday/pulls
since it isn’t means u did smth wrong.
Oh I see.
I think I have fixed this issue now.
Thanks
1 Like
Waxaz
August 15, 2017, 3:34pm
15
Hey, it’s Russia guy. I’ve just made a pull request, can you see it?
1 Like
diomed
August 15, 2017, 5:52pm
16
Very nice, both are merged. Thank you guys.
Keep them coming, developers!
2 Likes
Waxaz
August 15, 2017, 6:53pm
17
Thanks to YOU to give me an opportunity to practice git.
2 Likes
Hey, willing to do the UK - I know the fundamentals of github and JS so reckon I’ll be able to do that if you still need it?
If you’re happy with my contribution, I could also do Indonesian [Bahasa Indonesia] following that
1 Like
diomed
August 16, 2017, 8:25am
19
just do it, man. don’t need to ask.
if you see country is missing, it’s available.
1 Like
Hi, sorry it took me a little while - I was a bit more confused by github than I was expecting, I hope I did it correctly!
1 Like