Personal Portfolio -- feedback

all feedback is welcome :

note: colors isn’t my cup of tea

Love the opening animation. Might have a higher impact if it were centered vertically in the viewport.

The navbar links are margined off the page to the right for me.

I love how you used grid for the row sizing. I’ll have to try that sometime.

Cool animation!

Maybe the code could improve with classes. I’ve read that making the CSS independent of the exact markup you use by implementing classes is always best practice.

So instead of, say

p {
    /* some styling */

you would use

.text {
    /* rad styling going on here */

Happy coding! :slight_smile:

The use of BEM is popular when creating classes for your sites, you can look it up.

It’s awesome and couples perfectly with SASS, which is ahead in the fcc curriculum!