Personal Portfolio Welcome Section

For some reason, the test “Welcome Section equal to viewer height” is not passing, even though I have the code right on the welcome section (height: 100vh;) and it looks right on the screen.
Why isn’t it passing? It was earlier on, before I made some changes.


Help!

It’s not passing because of the padding-top here:

#welcome-section {
  ...
  padding-top: 5rem;
  ...

You can either remove this padding, or set box-sizing to border-box because at the moment the height is 100vh + 5rem :wink:

MDN: box-sizing

1 Like

Thank you soooo much!! I had box-sizing to border-box in my body element, but I guess that wasn’t good enough. I put it in my “*” element and it worked!