Please critique my Grace Hopper Tribute Page

Please critique my Grace Hopper Tribute Page
0

#1

Hello everyone, just completed a simple tribute page to Grace Hopper. <a href=“http://codepen.io/numanzor/pen/grVKBE” alt=Natalie’s Tribute Page">This is my first web page and I would greatly appreciate any and all constructive criticism. Thank you so much!


#2

HI :slight_smile:

HTML codepen linter:

  • The “div” element cannot be a child of the “ul” element.
  • The “li” element cannot be a child of the “div”
  • ‘alt’ is not a valid attribute of the “a” element.

at line 13-15:

<ul>
  <div class="adjust-width">
  <li>Grace studied Mathematics and Physics at Vassar College.</li>

at line 18-19

 </div>
</ul>  

at line 41

<li>The information for this tribute page was taken from <a href="https://en.wikipedia.org/wiki/Grace_Hopper" alt="Grace Hopper Wiki" >Grace Hopper's Wikipedia Page</a></li>

¿Why not use CSS?

$(".title").css("font-family", "Slabo 27px");
$("body").css("background-color", "rgb(225, 234, 234)");
$(".title").css("font-family", "serif");
$(".resize").css("width", "300px");
$(".resize").css("height", "auto");
$(".centered").css("text-align", "center");
$("img").css("display", "block");
$("img").css("margin-left", "auto");
$("img").css("margin-right", "auto");
$("figcaption").css("margin-bottom", "20px");
$(".tabbed").css("margin-left", "5%");
$("ul").css("margin-top", "-12px");
$(".adjust-width").css("width", "75%");
$("li").css("text-align", "justify");
$("p").css("margin-left", "7%");
$("li").css("margin-left", "8%");
$(".bold").css("font-weight", "bold");
$("iframe").css("display", "block");
$("iframe").css("margin-left", "auto");
$("iframe").css("margin-right", "auto");
$("h4").css("margin-top", "15px");
$(".adjusted-bottom").css("margin-bottom", "15px");

Cheers and happy coding :slight_smile:


#3

Thank you so much for your response! I truly appreciate it-will definitely go back and make the corrections you suggested. As for utilizing CSS, I completely agree-I was completely new to jQuery and just wanted to get more comfortable with the syntax through repetition.