Please provide feedback for my Tribute Page

Code Feedback
1

Finished with my first project Tribute page. Any feedback/suggestions are appreciated. Thank you.
https://codepen.io/ratanhegde08/pen/vYgqRLg

2

Hi @ratanhegde08 !

Welcome to the forum!

I think your page looks good.

Please review the lesson on giving links meaningful names.

Wikipedia page is not that accessible.

In your html you can have stray </body> tag with no start tag.
In codepen you do not need to include the body tags because that is already built into codepen.

Image tags need alt attributes.
You need to provide a description here

  <img src="https://api.time.com/wp-content/uploads/2018/06/muhammad-ali-pardon.jpg" alt="" id="image" />

Lastly, you have some repetition in your css with these properties

  display: flex;
  flex-direction: column;
  align-items: center;

Instead of adding those properties to individual classes you might consider creating a class and applying it to those elements you want to have those styles.

.flex-container {
  display: flex;
  flex-direction: column;
  align-items: center;
}

Hope that helps!

1 Like
3

Thank you very much for the help. I made the necessary changes to the link.
The trick with flex-container class is awesome thanks.

4

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.