Please provide feedback on tribute page :)

https://kieran-wade-code.github.io/Tribute/

Hi @kieranwade2021 !

Welcome to the forum!

I edited the title of your post.
Please avoid placing links in the title since we cannot click on them.

I think your page looks good.

I am not sure what the more button at the top is supposed to do.
When I click it, nothing happens.

I would also review the lesson on giving meaningful names to links.

Wikipedia is not that accessible.

Hope that helps!

Your page looks good @kieranwade2021. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script, with all tests passing, should be included when you submit your projects.
    • Your page passes 6/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
    • Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    • wikipedia” is not accessible
  • Shouldn’t his last name be capitalized?
  • The “more” button at the top of the page is a bad UX. It doesn’t do anything. Why have it?
  • Why is myBtn hidden? User’s that rely on keyboard navigation have a bad UX.
  • It’s not good practice to go from h1 to h5. Even more so when you then increase the font size of h5 to make it larger than what h5 would normally be.

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.