Portfolio Page - Feedback Please!

Portfolio Page - Feedback Please!
0.0 0

#1

Hey all,

Here’s the codepen to my personal portfolio page!

>>link<<

Obviously the site is full of placeholders and the social media links don’t lead anywhere (form does nothing too), but that’s very simple stuff to change about when I make a live version of the site. It should be nicely responsive and works pretty well. I used a fair amount of knowledge I already had before finding freeCodeCamp while making this.


#2

Nice! Good job :thumbsup:

It’s just me, but I feel like I’m drowning in horizontal lines, particularly in the social media section


#3

Hi :slight_smile:

Codepen CSSlint:

float can’t be used with display: inline-block.

.navbar {
   position: relative;
   float: right;
  vertical-align: top;
  display: inline-block; <-- here
  margin: 12.5px 0 0 ;
}

mdn documentation:

As float implies the use of the block layout, it modifies the computed value of the display values in some cases:
Specified value : inline-block
Computed value : block

Computed value: as the specified value, except for positioned and floating elements and the root element. In both cases the computed value may be a keyword other than the one specified.

Cheers and happy coding :slight_smile:


#4

Cheers! And fair enough, there are probably too many.

Thanks for pointing that out, got rid of the display.