Portfolio page feedback?

Code Feedback
1

Hi all, here’s what I have for my portfolio page so far. I really like the scrolling effect that I’ve seen in many pages, but I’m thinking that might require JS(?) and I’ll be able to add it in later.

Any feedback would be super appreciated. Thank you :slight_smile:

2

oof. uploaded my portfolio site to my domain and it just doesn’t look the same as in codepen. :sob:
I obviously need to make some edits/get more familiar with bootstrap. I know this will be a great learning experience in the end, but definitely quite frustrating atm. :persevere:

3

Hello @drake-king,

HTML

  • error

The “big” element is obsolete. Use CSS instead.

From line 37 to line 37:

<h1><big><strong>Drake King</strong></big></h1>

MDN documentation:
<big>: The Bigger Text element - HTML: HyperText Markup Language | MDN

The obsolete HTML Big Element (<big>) renders the enclosed text at a font size one level
larger than the surrounding text (medium becomes large, for example). The size is capped at the
browser’s maximum permitted font size.

---
  • Do not use lower levels to decrease heading font size:
  <a href="#about">
    <h3>About</h3>
  </a>

MDN documentation:
<h1>–<h6>: The HTML Section Heading elements - HTML: HyperText Markup Language | MDN

Do not use lower levels to decrease heading font size: use the CSS font-size property
instead

---

CSS

  • error

CSS: “text-align”: “justified” is not a “text-align” value

From line 27 to line 27:

#about {
...
  text-align: justified;
}

MDN documentation:
text-align - CSS: Cascading Style Sheets | MDN

/* Keyword values */
text-align: left;
text-align: right;
text-align: center;
text-align: justify; ← here
text-align: justify-all;
text-align: start;
text-align: end;
text-align: match-parent;

/* Block alignment values (Non-standard syntax) */
text-align: -moz-center;
text-align: -webkit-center;

/* Global values */
text-align: inherit;
text-align: initial;
text-align: unset;

---
  • error

CSS: “text-size”: Property “text-size” doesn’t exist.

From line 28 to line 28:

#about {
...
  text-size: 48px;
}

MDN documentation:
font-size - CSS: Cascading Style Sheets | MDN

DESIGN

cheers and happy codding :slight_smile:

--- Note:

serve - npm

Getting Started with Headless Chrome  |  Blog  |  Chrome for Developers

2 Likes
5

Ok, made some changes and uploaded to my own domain. I will keep updating this as I learn more (about to start the javascript portion of Web Dev Bootcamp, and then the javascript portion of FCC), but I think this one is better than the last attempt :slight_smile:

thanks for feedback! any additional is welcomed :slight_smile:

http://www.drakeaking.com/