Portfolio project, any feedback?

Code Feedback
1

Hi,
I tried doing the portfolio project, I would appreciate some feedbacks and/or advices.

I’ve had some troubles putting two <"div> next to each other, especially in the contact section, where I tried putting the text on the right, next to the form. Instead, it’s below.

Thank you in advance!

2

Are those drawings yours? If so, good job. Some of them are awesome.

As for your portfolio, you should keep the CSS in the CSS panel; it just makes it easier to modify if you ever need to. Also, links to other scripts should be in the pen settings. Then:

  • Give your .scrollmenu a z-index, 'cause as it is it’s covering your content (z-index:2 should suffice).

  • You have an unclosed <row> tag which should be closed and should be <div class="row">. Also, the next div should have a col class and maybe an alignment class (using bootstrap, every div inside of a row should be a col).

   <div class="row">
     <div class="col-12 text-center">
        <img class="crop" src="">
        ....
     </div>
  </div>

This way your images will be centered thanks to the “text-center” class.

  • Your last section (the contact form) has too many wrapping divs, keep it simple like your other sections: Then if you want the text to be on the side, use the grid system again. Something like this (that of course you would have to adjust to your needs):
<div id="contact_section" class="container">
  <h3 style="text-align: center;">Contact me</h3>
  <hr width="25%">
  <div class="row">
    <div id="contact" class="col-6">
      <input type="text" placeholder="Name" required>
      <input type="text" placeholder="Email" required>
      <input type="text" placeholder="Phone number">
      <input type="text" placeholder="Message" required> 
      <button class="button" type="submit">Submit</button>
    </div>
    <div class="col-6">
      <p>Feel free to message me if you have any question or request, I'll make sure to reply as soon as possible.</p>
    </div>
  </div>
  <div style="text-align: center;">
    <a href="#" target='_blank' class="fa fa-facebook"></a>
    <a href="#" target='_blank' class="fa fa-twitter"></a>
  </div>
</div>

Aside from that, good work!

1 Like
3

Hi,

Everything I put on the page is mine, so thank you!

About the project, I wasn’t sure about the CSS, since it was said to put it this way on the previous project, but it is indeed easier to put it on the CSS panel.

I’ll work on the rest with the advices you gave me.

Thank you for your time and your help!

1 Like