Product landing page prroject feedback

Project Feedback
#1

Hello fellow campers. Complete my landing page project recently, so what do you think? What should I improve or change?
It was intresting project simply because how much new I learned about styling my elements. Skewing elements, some flexboxes and also my first grids.
https://codepen.io/jorjif/pen/XWNqjZN

1 Like
#2

Hi @jorjif !

I think your page looks good.

There are a couple of spelling errors

Ex. Web bascis and Our programm

I would add the cursor: pointer; to the Mail me button.

You might consider adding a smooth scroll to the page.

html {
  scroll-behavior: smooth;
}

You don’t need html tags for codepen.

The video does not load for me.
You might consider using the embed option.

<iframe width="560" height="315" src="https://www.youtube.com/embed/xb8G8qA9ibI" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>

Hope that helps!

#3

Your page looks good @jorjif. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address. (It’s a typo, easy fix.)
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
#4

Thanks for the crtic! I fixed issues that you mentioned, so is it better now?

#5

Wow, thanks! Smooth scroll really give a much of a difference! Is it so much better now

#6

Good job cleaning things up @jorjif.

Again, I would say to not use the br element to force the line break.

  • Instead of using <br> elements to have each inline element on a new line, use or set container elements to be block-level elements so they’ll each take up the full width.