Product Landing Page - PyCharm

Hi! Iโ€™ve finally finished the third project :relieved:

It is pretty basic as usual, but I would really appreciate any feedback on how to make it better. Thank you for your time :pray:

https://codepen.io/lancelote/pen/yLYmYqq

1 Like

Hello there,

I like the layout of this project, and it is semi-responsive, but the video is not responsive, and it preventing it looking the best it can on mobile-sized screens.

I particularly like the navbar :wink:

Keep it up!

1 Like

Oops, I forgot about making the video responsive. Will fix. Thank you :pray:

Turns out it is quite tricky to do. Even the reference solution doesnโ€™t have a responsive video frame. I ended up using the following solution https://alistapart.com/article/creating-intrinsic-ratios-for-video/ which is surprisingly more complicated than I initially thought it would be.

Your page looks good @lancelote. Something to revisit;

  • For HTML5, the frameborder attribute on the iframe element is obsolete. Use border on iframe in CSS instead.
1 Like

Right, thank you, fixed :pray: