Product Landing Page: Rolex Sky-Dweller

Code Feedback
1

Hi! I just finished my third project and I would like to receive comments.

Thank you!

1 Like
2

Hello, alvaro.

Excellent job on the product landing page. Interesting choice of product, as well. The only thing I would change is the colour of the navbar so that there is more contrast between it and the main body.

Keep it up.

3

Hi @arganarazalvaro, nice job on your page!

4

Very nice, looks good. A few things:

  • Get rid of the pointer cursor when you hover over the Rolex image at the top left. It makes it look like a link when it is not.
  • At larger font sizes your getting a bunch of content/button overlap as you narrow your browser (before it reaches one of your media breakpoints).
  • Your email input width is too small, especially at larger font sizes. And you need a <label> for it.

One possible way to fix some of these font issues is to base your media breakpoints on em’s instead of pixels (or a combination of both). Basically, you can’t assume what font size the user is going to be viewing your page with and should thus make sure it can handle very big sizes.

5

Thanks for the comments, I have made some improvements.