Profile Lookup does not work

Profile Lookup does not work
0.0 0

#1

Tell us what’s happening:
Hi!
I am a begginer and i am trying to understand what is wrong in below code.
In my opinion is easiest way to pass this through.
Can somebody please help me to understand when I made a mistake?

Your code so far

//Setup
var contacts = [
    {
        "firstName": "Akira",
        "lastName": "Laine",
        "number": "0543236543",
        "likes": ["Pizza", "Coding", "Brownie Points"]
    },
    {
        "firstName": "Harry",
        "lastName": "Potter",
        "number": "0994372684",
        "likes": ["Hogwarts", "Magic", "Hagrid"]
    },
    {
        "firstName": "Sherlock",
        "lastName": "Holmes",
        "number": "0487345643",
        "likes": ["Intriguing Cases", "Violin"]
    },
    {
        "firstName": "Kristian",
        "lastName": "Vos",
        "number": "unknown",
        "likes": ["Javascript", "Gaming", "Foxes"]
    }
];


function lookUpProfile(firstName, prop){
// Only change code below this line
for (var i = 0; i < contacts.length; i++) {
if (contacts[i].firstName == firstName && contacts[i].hasOwnProperty(prop)){
    return contacts[i][prop];
    } else if (firstName == contacts[i].firstName && prop != contacts[i][prop]){
      return "No such property";
    } else {
      return "No such contact";
    }
}
// Only change code above this line
}

// Change these values to test your function
lookUpProfile("Harry", "Magic");

Your browser information:

Your Browser User Agent is: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36.

Link to the challenge:


#2

I think your else case returns in all failing cases, thus breaking the loop. So your check loop never gets past the first iteration.


#3

Now I get it. It was so simple! Thank you Puukallistaja!
It is hard to be at the beggining :slight_smile: