Profile Lookup Help20

Tell us what’s happening:
All the tests run except “Bob”, “potato” should return “No such contact”
Not understanding why

Your code so far


//Setup
var contacts = [
    {
        "firstName": "Akira",
        "lastName": "Laine",
        "number": "0543236543",
        "likes": ["Pizza", "Coding", "Brownie Points"]
    },
    {
        "firstName": "Harry",
        "lastName": "Potter",
        "number": "0994372684",
        "likes": ["Hogwarts", "Magic", "Hagrid"]
    },
    {
        "firstName": "Sherlock",
        "lastName": "Holmes",
        "number": "0487345643",
        "likes": ["Intriguing Cases", "Violin"]
    },
    {
        "firstName": "Kristian",
        "lastName": "Vos",
        "number": "unknown",
        "likes": ["JavaScript", "Gaming", "Foxes"]
    }
];


function lookUpProfile(name, prop){
// Only change code below this line

  for (var i = 0; i < contacts.length; i++) {
    
      if(contacts[i].hasOwnProperty(prop) && (contacts[i].firstName === name)) {
        return contacts[i][prop];
      } else if(!(contacts[i].hasOwnProperty(prop))) {
        return "No such property";
      }    
    }
    return "No such contact";
// Only change code above this line
}

// Change these values to test your function
lookUpProfile("Akira", "likes");

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.62 Safari/537.36.

Link to the challenge:
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/profile-lookup

Your problem is in your else if condition. Currently your code checks to see if any contact does not have the property (prop) passed in as a parameter. You should look at your first condition for inspiration on this:

// check that the property exist for the contact with the same firstName
contacts[i].hasOwnProperty(prop) && (contacts[i].firstName === name)

Hope this helps without giving too much away as you have all the code you need to get it working :slight_smile:

1 Like

Thank you got it! Simple error