Profile Lookup Javascript Help

Profile Lookup Javascript Help
0.0 0

#1

Tell us what’s happening:
Im having trouble with one javascript challenge, I don’t understand why it is failing. Am I missing something here or maybe the testing script not working all the way? Here is the tests that are failing:
“Kristian”, “lastName” should return “Vos”
“Sherlock”, “likes” should return [“Intriguing Cases”, “Violin”]
“Harry”,“likes” should return an array

Your code so far


//Setup
var contacts = [
    {
        "firstName": "Akira",
        "lastName": "Laine",
        "number": "0543236543",
        "likes": ["Pizza", "Coding", "Brownie Points"]
    },
    {
        "firstName": "Harry",
        "lastName": "Potter",
        "number": "0994372684",
        "likes": ["Hogwarts", "Magic", "Hagrid"]
    },
    {
        "firstName": "Sherlock",
        "lastName": "Holmes",
        "number": "0487345643",
        "likes": ["Intriguing Cases", "Violin"]
    },
    {
        "firstName": "Kristian",
        "lastName": "Vos",
        "number": "unknown",
        "likes": ["JavaScript", "Gaming", "Foxes"]
    }
];


function lookUpProfile(name, prop){
// Only change code below this line
for (var i = 0; i < contacts.length; i++){
  if (contacts[i].firstName == name){
    if (contacts[i].hasOwnProperty(prop)){
      return contacts[i][prop];
    }
    else {
      return "No such property";
    }
  }
  return "No such contact";
}
// Only change code above this line
}

// Change these values to test your function
lookUpProfile("Akira", "likes");

Your browser information:

User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36.

Link to the challenge:
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/profile-lookup


#2

Your function only iterates one time through the contacts array, so only the first contact is checked before you return. Remember, as soon as a return is executed, the function is immediately exited. Think about when you should return “No such contact”.


#3

Oh my, you are right I kept puzzling over the top part of the code and I didn’t even realize I put that return inside the for loop instead of after it. Thanks!