ProfileLookUp code not working, why?

Tell us what’s happening:
I do not understand why it says contacts[i] is undefined. Isn’t contacts[i] the name of the object of position i within the array ‘contacts’?

It also seems to me that my code generally is a failure but unfortunately i cannot see why. Please help me :[

  **Your code so far**

// Setup
var contacts = [
  {
      "firstName": "Akira",
      "lastName": "Laine",
      "number": "0543236543",
      "likes": ["Pizza", "Coding", "Brownie Points"]
  },
  {
      "firstName": "Harry",
      "lastName": "Potter",
      "number": "0994372684",
      "likes": ["Hogwarts", "Magic", "Hagrid"]
  },
  {
      "firstName": "Sherlock",
      "lastName": "Holmes",
      "number": "0487345643",
      "likes": ["Intriguing Cases", "Violin"]
  },
  {
      "firstName": "Kristian",
      "lastName": "Vos",
      "number": "unknown",
      "likes": ["JavaScript", "Gaming", "Foxes"]
  }
];


function lookUpProfile(name, prop) {
// Only change code below this line
var i = 0;
while (contacts[i].hasOwnProperty(name) === false && i !== contacts.length) {
i++;
}

if (i === contacts.length) {
return "No such contact";
} else if (contacts[i].hasOwnProperty(prop) === true) {
return prop;
} else {
return "No such Property";
}
// Only change code above this line
}

lookUpProfile("Akira", "likes");
  **Your browser information:**

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Challenge: Profile Lookup

Link to the challenge:

A couple of things.

contacts[i].hasOwnProperty(name)

Are you sure that is what you want to check for?

return prop

If both are true, then return the “value” of that property.

1 Like

image

when i is 4, contacts[4] is undefined, which doesn’t have a hasOwnProperty method - consider which condition has to be checked first to avoid the error

1 Like

My brain is tomato, i cannot thank you enough!

Those two contributions fixed my code almost completely (99%).
The only thing missing was the fact that JS is case-sensitive haha

It seems i can only mark one post as the solution?? I’ll just mark this one and say that ilenia’s and lasjorg’s post were the real solution until i know better.

So this is were i should make use of shortcircuit evaluation! Now i understand what JavaScript was trying to tell me. Thank you very much!

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.