Project feedback landing page

Code Feedback
1

Hi guys,

This is my landing page, sort of done, my goal was to make it similar to the one on the curriculum but on my own, I tried making the menu hamburger like but I had hard time with the logo, if anyone has advice for that I’d appreciate to hear. Also a general feedback overall, thanks.

2

HI @TheOctagon3323 !

I think your page looks good.

The reason why your navlinks aren’t working is because you placed the ids and href values in the same place

<a class="nav-link" href=#Pricing id="Pricing" >

The id should be with the element you want to go to.
For example, the pricing id should be in the section element for the price section.

<section id="Pricing">

  <ul class="listdrop">
    <li class="card-head">Beginner</li>

Hope that helps!

3

Thanks for the feedback :slight_smile:
I fixed it, only question is why my about won’t navigate?

<li> <a 
       class="nav-link"
       href=#midpage
       id="midpage"
         >About</a></li>

<section id="midpage">
</section>

Can it be because the page is too short? but if I scroll down enough it’s still wont jump back. Thanks :slight_smile:

4

You can’t have duplicate ids.
Also, it might help to review that FCC html lesson on internal links.
Hope that helps

5

Okay, thanks for your help cheers :slight_smile:

6

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.