Project: Tribute Page completed

Looking for constructive feedback, what did you like/not like, what would you change?


Thank you for your thoughts!

Hi @troyb16 !

I think your page looks good.

Just a few notes from me

You have a couple of errors in your html.
Run your code through the codepen analyzer to find and fix those errors.

You can also use the html validator to find and fix those errors

For codepen, you don’t need the html boilerplate code here because it is already built into codepen.

<!DOCTYPE html>
<html lang="en">

    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Ken Block Tribute Page</title>
    <link rel="stylesheet" href="styles.css">

For accessibility reasons, I think your link text at the bottom of wikipedia entry could be more descriptive.
You learned about that in this lesson.

You could use the shorthand margin and padding properties for cases like this

  padding-top: 2.5em;
  padding-bottom: 2.5em;

you could rewrite like so

padding:2.5em 0;

Hope that helps!


Hey @jwilkins.oboe !

Wow thank you for such descriptive and helpful feedback I really appreciate that a lot! I’ll definitely look into all that and make some changes!

Thank you!!! :smiley:

1 Like

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.