Projects feedback for Drum machine

Code Feedback
1

I welcome any feedback or critique. Here’s the link.
Also, please take a look at my calculator. It’s pretty bare-boned(I’ll call it minimal :stuck_out_tongue_winking_eye:)

2 Likes
2

Hey it looks really great! I liked the UI a lot.

I noticed that kick is not working. Also keypresses won’t work.

Cheers :slight_smile:

3

Thanks a lot for your feedback. I’m working on ironing out all the bugs and making this cross-browser compatible. I’ve only tested in chrome so far.

4

Hey @onecastell
Looks really great :smiley:

  • When you select the mute button, it mutes. When I select again, it says mute. It should just unmute on the second time.
  • If you do a double click quickly on the mute button, it stays unmute. Is it a timing thing?
  • Bottom right button does what? on hover should say :slight_smile:

Keep up, love your personal website :smiley:

5

On the calculator, AC is difficult to read. So far looks good. I wonder if you should use some kind of different identity to distinguish between the numbers and the operations.

Good luck :slight_smile:

6

Thanks a ton! :smile:
The bottom right button is supposed to change the selection of sounds to another kit. I haven’t coded that part yet because I wanted to pretty much just pass the FCC tests before adding any refinements.
Thanks again for your feedback. I truly appreciate it! :+1:t6:

1 Like
7

Thanks. I adjusted the color shade of the AC button and applied a color contrast to differentiate between operator and digit buttons.