Random quote generator-feedback

Random quote generator-feedback
0

#1

Hi everyone,
I have completed my random quote generator project, please give feedback and any changes to make it better.


#2

Can you edit your post and add a link to your project?


#3

hello,
I have edited the post and added the link of random quote generator.
please give me the feedback


#4

The style is ok. There are some minor problems. I cannot tweet the quote.
The background looks good on a desktop but not so good on a mobile view.

This CSS would be better I think:

  background-size:cover;
  background-repeat: no-repeat;
  background-attachment: fixed;

#5

Thank you for giving feedback,I will change them.
I don’t know how to add the tweet the quote, can u help me?


#6

Sure

    $('#tweet-this').click(function() {
       var tweetJoke = $(".message").text();
       if (tweetJoke != 'Press below for a joke') {
         window.open('https://twitter.com/intent/tweet?text="' + tweetJoke + '"', '_blank');
       };
    });

#7

hello
I have updated my random quote generator by adding API and tweet button.please give me feedback
and help me to adjust the position of tweet button.