React Drum Machine Project

Code Feedback
1

Hey there!
Finally I’ve completed my drum machine project :slight_smile:
Two more projects for the front end library!

C&C are welcome! :slight_smile:

DRUM MACHINE

2

It looks good @Eidan. Some things to revisit;

  • Color contrast needs to be improved. Someone with poor eyesight will have a hard time distinguishing keys
  • On that same note, someone using a keyboard only has no accessability
  • It’s not responsive. Elements fall out of place on smaller screens.
    • For instance, add border: solid 1px black; to the #container selector
3

Thanks a lot! I’ve changed the responsiveness and the contrast. Now I’ve to learn about the accessibility… :thinking: