Record Collection conditions issue

Tell us what’s happening:
When I run the code in codepen, it updates as requested, but it won’t pass FCC tests.

These are the errors:

updateRecords(…)[5439].tracks.pop is not a function
After updateRecords(2548, “tracks”, “”), tracks should not be set

Also, I’m confused regarding what the challenge requests-

If value is empty (""), delete the given prop property from the album.

and what it actually tests-

tracks should not be set

Your code so far

// Setup
var collection = {
    "2548": {
      "album": "Slippery When Wet",
      "artist": "Bon Jovi",
      "tracks": [ 
        "Let It Rock", 
        "You Give Love a Bad Name" 
    "2468": {
      "album": "1999",
      "artist": "Prince",
      "tracks": [ 
        "Little Red Corvette" 
    "1245": {
      "artist": "Robert Palmer",
      "tracks": [ ]
    "5439": {
      "album": "ABBA Gold"
// Keep a copy of the collection for tests
var collectionCopy = JSON.parse(JSON.stringify(collection));

// Only change code below this line
function updateRecords(id, prop, value) {
 if (!collection[id][prop] && prop != "tracks") {
    collection[id][prop] = value;
  } else if (value !=="" && collection[id][prop]) {
    } else if (collection[id].hasOwnProperty("tracks") === false && prop === "tracks") {
        collection[id][prop] = [];
     } else if (value === "") {
         delete collection[id][prop];
       }  return collection;

// Alter values below to test your code
updateRecords(5439, "artist", "ABBA");

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36.

Link to the challenge:

Your code does work, but you may either need to refresh the page or use a browser like Chrome.

1 Like

Yes! Thank you!
Do you want me to delete this thread?
I’m sorry.