Hi guys!
I hope your are going well. and please review my landing page, I want to know my improvement, so if it pleases you give me some feedback and I will appreciate it, thanks.
Here is the link,https://codepen.io/DiuG/pen/zYBQbYQ?editors=1100
Hi @Diu!
I think your page looks good.
I would move the javascript out of the html and into the javascript section.
This is optional but I might personally write it like this
let menubtn = document.getElementById("menubtn");
let navbar2 = document.getElementById("navbar2");
let menu = document.getElementById("menu");
menubtn.onclick = () => navbar2.style.right==="-250px" ? navbar2.style.right="0": navbar2.style.right="-250px";
Remember to keep the test suite in the page
<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>
You might consider adding a smooth scroll to the page
html {
scroll-behavior: smooth;
}
Your page looks good @Diu. Something to revisit;
- When the user clicks to go to the “work” section the navbar seems to disappear. White text on a white background is not a good UX.
Clicking “deals” gives the same bad UX though a little portion of the box around login does show. - As mentioned, keep the test script when forking the pen (
<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>
)- The test script should be included, with all tests passing, when you submit your projects.
Thanks so much for your kind feedback, I have changed the nav text to black so that it can appear clear in the work section, thanks once again.
Thanks my dear for your kind feedback, I have added the smooth scroll and have exported the script to it’s Js file, thanks once again.