So I recently finished the first project under the Responsive Web Designs Projects and decided to dedicate it to 2020, a year that has been pretty tough. I hope you all enjoy looking at it. Any Feedback is absolutely welcomed. Thank You
1 Like
Welcome to the forums @jashmagash. Your page looks good. Nice use of the parallax effect. Some things to revisit;
- Keep the test script when forking the pen (
<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>
).- The test script should be included, with all tests passing, when you submit your projects.
- Your page passes 9/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
- Codepen provides the boilerplate for you. It only expects the code youâd put within the
body
element in HTML. (No need to include thebody
tags). For anything you want to add to the<head>
element click on the âSettingsâ button, then HTML and add it into the âStuff for <head>â box. - Run your HTML code through the W3C validator.
- There are HTML coding errors you should be aware of and address.
- Since copy/paste from codepen you can ignore the first warning and first two errors.
- Do not use the
<br>
element to force line breaks or spacing. Thatâs what CSS is for. - Review the lesson about giving meaningful text to links.
- Web Accessibility in Mind has a more thorough explanation.
- âclick hereâ is not accessible
1 Like
Thank You so much for the feedback. I really appreciate it
1 Like
Youâre welcome. After you revisit the issue, repost so we can have another look.
Happy coding!
This is the corrected version of the previous code,
Iâm sorry it took so long
@jashmagash, please watch the language. Some may find this offensive.
Some things were cleaned up, others were not. As mentioned previously;
- Keep the test script when forking the pen .
- The test script should be included, with all tests passing, when you submit your projects.
- Your page passes 8/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
- Your tribute links, dark blue on a jumbled background cannot be read. Thereâs no contrast.
I didnât notice the link. It was white before
Thank you for the feedback