Responsive Web Design Project - Build a Tribute Page

Code Feedback
1

Hello. I’ve just completed my first project page and would love to get some feedback.

https://codepen.io/sam-g-code/full/eYJpqKG

Thanks

Sam

1 Like
2

Hello @sam-g-code,

Welcome to the forum.

Your page looks great. All the elements are responsive, something I myself find sometimes a little challenging. Great work on that.

Considering the background of the page and the image of Bill Nicholson, perhaps adding a little bit of shadow/z-index on the image might be a little touch-up you may add to the page.

Also please note that passing all the tests is also a criteria before submitting the project here. You may want to look into which tests are not being passed by the page yet and may make the corresponding changes.

Overall, you have done an amazing job. I will definitely like to see more of your work. :smiley:

3

Hellow @kamalpreetgrewal

Thanks for taking the time to have a look and for your tips. I’ve added some shadow which I like.

Can I ask which tests are not showing as passed as they’re all showing correct for me?

4

Welcome to the forums @sam-g-code. Your page looks good. Some notes;

5

Thanks @Roma

I’ll remember not to use the body tags on codepen next time.

Yes I remember that lesson now, thanks I’ll make sure I think about it in the future.

6

Hi, nice work there bro. I really do not have a contribution but a question, did you use JS too for the project? Seeing we’ve only started learnt CSS and HTML. The whole thing looks scary to me. I don’t know where to start.

7

@Obong

With static information pages like these, I believe we do not need to use JS to complete the project. I know it may seem a little bit daunting but this project can be very well accomplished using only what we learned in HTML and CSS here.

Good luck on moving ahead. :slightly_smiling_face:
In case you have any issues while working on your project, discuss them here. We are all here to help each other.

1 Like
9

@sam-g-code

All your tests are passing at my end. There was a silly mistake at my end. I missed updating the testing url. Silly me. The page looks good overall now.

1 Like