Review JavaScript Fundamentals by Building a Gradebook App - Step 4

Tell us what’s happening:

I don’t understand why it is assuming that a student with a grade of “F” has passed.
" if (hasPassingGrade = true) " I do believe the problem might be in this section but I can’t understand why.

Your code so far

function getAverage(scores) {
  let sum = 0;

  for (const score of scores) {
    sum += score;
  }

  return sum / scores.length;
}

function getGrade(score) {
  if (score === 100) {
    return "A++";
  } else if (score >= 90) {
    return "A";
  } else if (score >= 80) {
    return "B";
  } else if (score >= 70) {
    return "C";
  } else if (score >= 60) {
    return "D";
  } else {
    return "F";
  }
}

function hasPassingGrade(score) {
  return getGrade(score) !== "F";
}


// User Editable Region

function studentMsg(totalScores, studentScore) {
  let classAverage = getAverage(totalScores);
  let studentGrade = getGrade(studentScore);
  if (hasPassingGrade = true){
    return ("Class average: " + classAverage +". Your grade: " + studentGrade + ". You passed the course.")
  }
  else {
    return ("Class average: " + classAverage + ". Your grade: " + studentGrade + ". You failed the course.")
  }
}
console.log(studentMsg([92, 88, 12, 77, 57, 100, 67, 38, 97, 89], 37));

// User Editable Region


Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36

Challenge Information:

Review JavaScript Fundamentals by Building a Gradebook App - Step 4

This is not doing what you think it is doing.

I will try rewriting it differently I guess

You should investigate why I said what I said.

What do you want that check to do? What does = actually do?

It’s mainly used to give a value to a variable, correct? I should be using either == or ===

Try it and see. That sounds like a good theory.

It is still not accepting it as correct. I get the following message on the console:

// running tests 2.

studentMsg([56, 23, 89, 42, 75, 11, 68, 34, 91, 19], 100)

should return the following message:

"Class average: 50.8. Your grade: A++. You passed the course."

Your studentMsg function should return the correct message based on the student’s score and the class average. // tests completed // console output Class average: 71.7. Your grade: F. You failed the course.

I unfortunately cannot comment on code I cannot see :wink: My crystal ball is in the repair shop

1 Like
function getAverage(scores) {
  let sum = 0;

  for (const score of scores) {
    sum += score;
  }

  return sum / scores.length;
}

function getGrade(score) {
  if (score === 100) {
    return "A++";
  } else if (score >= 90) {
    return "A";
  } else if (score >= 80) {
    return "B";
  } else if (score >= 70) {
    return "C";
  } else if (score >= 60) {
    return "D";
  } else {
    return "F";
  }
}

function hasPassingGrade(score) {
  return getGrade(score) !== "F";
}


// User Editable Region

function studentMsg(totalScores, studentScore) {
  let classAverage = getAverage(totalScores);
  let studentGrade = getGrade(studentScore);
  if (hasPassingGrade == true){
    return ("Class average: " + classAverage +". Your grade: " + studentGrade + ". You passed the course.")
  }
  else {
    return ("Class average: " + classAverage + ". Your grade: " + studentGrade + ". You failed the course.")
  }
}
console.log(studentMsg([92, 88, 12, 77, 57, 100, 67, 38, 97, 89], 37));

// User Editable Region


This is what I have so far

what is hasPassingGrade?

Ok, now there is a second reason why this line doesn’t do what you want. What sort of thing is hasPassingGrade?

To reply to both of you, hasPassingGrade means having a grade such as "A++, A, B, C and D

That’s not quite what I asked. What type of thing is this hasPassingGrade?

Oh, it is a function as far as I am aware

I got it…
I had to give a parameter to the function…

Thank you for your help! :slight_smile:

1 Like