# Review my random quote machine project **URL:** \ **Category:** I Built This\ **Created:** [August 10, 2016, 3:40pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946 "2016-08-10T15:40:23Z")\ **Posts on this page:** 18\ **Page:** 1
**Author:** ![Uolken](https://avatars.discourse-cdn.com/v4/letter/u/e5b9ba/32.png) [@Uolken](https://forum.freecodecamp.org/u/Uolken)\ **Post date:** [August 10, 2016, 3:40pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/1 "2016-08-10T15:40:23Z")
I just finished this project. Reviews needed link - [http://codepen.io/Uolken/full/oLJzRN/](http://codepen.io/Uolken/full/oLJzRN/) Thanks ---
**Author:** ![svmi3195](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/svmi3195/32/89111_2.png) [@svmi3195](https://forum.freecodecamp.org/u/svmi3195)\ **Post date:** [August 10, 2016, 3:59pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/2 "2016-08-10T15:59:58Z")
It works and I quite liked the design. However I don’t see tweet button (which is required by user stories). When I hover my mouse over “more” button I would expect the cursor become “hand”, but it becomes thin line like for text selection. ---
**Author:** ![Uolken](https://avatars.discourse-cdn.com/v4/letter/u/e5b9ba/32.png) [@Uolken](https://forum.freecodecamp.org/u/Uolken)\ **Post date:** [August 10, 2016, 4:17pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/3 "2016-08-10T16:17:35Z")
Thanks for feedback! I fix the cursor, as you say. Twiiter button placed in right bottom part of “machine”. Thanks again! ---
**Author:** ![xavierartot](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/xavierartot/32/160720_2.png) [@xavierartot](https://forum.freecodecamp.org/u/xavierartot)\ **Post date:** [August 10, 2016, 7:11pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/4 "2016-08-10T19:11:31Z")
WOW, where is the RANDOM ??? ---
**Author:** ![Uolken](https://avatars.discourse-cdn.com/v4/letter/u/e5b9ba/32.png) [@Uolken](https://forum.freecodecamp.org/u/Uolken)\ **Post date:** [August 10, 2016, 7:27pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/5 "2016-08-10T19:27:23Z")
I’m sorry, what’s a problem? I just check it, all works correct. If you have troubles, please give me more information. ---
**Author:** ![xavierartot](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/xavierartot/32/160720_2.png) [@xavierartot](https://forum.freecodecamp.org/u/xavierartot)\ **Post date:** [August 10, 2016, 7:42pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/6 "2016-08-10T19:42:37Z")
the quote need to be random not just printed??? ---
**Author:** ![Uolken](https://avatars.discourse-cdn.com/v4/letter/u/e5b9ba/32.png) [@Uolken](https://forum.freecodecamp.org/u/Uolken)\ **Post date:** [August 10, 2016, 7:46pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/7 "2016-08-10T19:46:20Z")
Yes, i just try it, quotes are random. It can repeat, but it’s API problem. If you got same quotes, i think, troubles on your side. ---
**Author:** ![xavierartot](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/xavierartot/32/160720_2.png) [@xavierartot](https://forum.freecodecamp.org/u/xavierartot)\ **Post date:** [August 10, 2016, 7:48pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/8 "2016-08-10T19:48:16Z")
they’re not random, sorry. you have to use the random method to be RANDOM, wtf > **[Math.random()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/random)** > > The Math.random() function returns a floating-point, pseudo-random number in the range from 0 inclusive up to but not including 1 — which you can then scale to your desired range. The implementation selects the initial seed to the random number... ---
**Author:** ![Uolken](https://avatars.discourse-cdn.com/v4/letter/u/e5b9ba/32.png) [@Uolken](https://forum.freecodecamp.org/u/Uolken)\ **Post date:** [August 10, 2016, 7:55pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/9 "2016-08-10T19:55:43Z")
I’m not sure about your problem. In this project i use external API [Random Famous Quotes](https://market.mashape.com/andruxnet/random-famous-quotes). I get random quotes by AJAX without any Math methods. On my PC and Android i got random quotes, so i think problem on your side, or just bugs in API ---
**Author:** ![xavierartot](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/xavierartot/32/160720_2.png) [@xavierartot](https://forum.freecodecamp.org/u/xavierartot)\ **Post date:** [August 10, 2016, 7:59pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/10 "2016-08-10T19:59:41Z")
I see now, but where is your programming I don’t think is the right think, whatever you said. Finally your just print a data from a database, so why not… ---
**Author:** ![Uolken](https://avatars.discourse-cdn.com/v4/letter/u/e5b9ba/32.png) [@Uolken](https://forum.freecodecamp.org/u/Uolken)\ **Post date:** [August 10, 2016, 8:09pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/11 "2016-08-10T20:09:17Z")
I understand you. But if you check other projects, you’ll see, that at least half use external APIs. I think, its normal in programming to use something, that work as you need, even it created other people. Yes, i can add array with quote objects and function, that will random pick them. But i’m not sure about efficiency. Anyway, thanks for feedback and sorry for my English ---
**Author:** ![jinrawx](https://avatars.discourse-cdn.com/v4/letter/j/ecc23a/32.png) [@jinrawx](https://forum.freecodecamp.org/u/jinrawx)\ **Post date:** [August 10, 2016, 8:10pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/12 "2016-08-10T20:10:35Z")
Very original design! I feel like I’m studying for a quiz with flashcards, aha. Suggestions: - Fixing the mobile layout - Adding hover styles to the buttons - Increasing the size of the font + rearranging where the quote is. There’s a lot of space that can be utilized in the quote container/flashcard area. - Bring the quote machine a bit closer to the title. - Add links to your github/codepen profile. - Change the background to a more lively/brighter color. Black seems a tad bit too dark. - Format the quote with the conventional style, having quote marks around the quote and a dash before the author. Would be nice if you did this for the twitter function as well. That’s all I can think of! Good job and I hope you take some of my suggestions. 😸 ---
**Author:** ![Uolken](https://avatars.discourse-cdn.com/v4/letter/u/e5b9ba/32.png) [@Uolken](https://forum.freecodecamp.org/u/Uolken)\ **Post date:** [August 10, 2016, 8:21pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/13 "2016-08-10T20:21:35Z")
Thanks for feedback and recomendations! I think, i wil follow your tips. Maybe, tomorrow i’ll add some design improvement, as you say. Thanks again! ---
**Author:** ![jjcsinke](https://avatars.discourse-cdn.com/v4/letter/j/d9b06d/32.png) [@jjcsinke](https://forum.freecodecamp.org/u/jjcsinke)\ **Post date:** [August 13, 2016, 10:52pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/14 "2016-08-13T22:52:44Z")
I think going for going for the API connection is more interesting than doing a random pick from an array, I know I had some problems finding one and getting it to work. Other than coming up with a meaningful list of quotes by yourself maybe, but we are not in a writers class 😉 ---
**Author:** ![IsaacAbrahamson](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/isaacabrahamson/32/30882_2.png) [@IsaacAbrahamson](https://forum.freecodecamp.org/u/IsaacAbrahamson)\ **Post date:** [August 14, 2016, 12:31am UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/15 "2016-08-14T00:31:54Z")
I think it is cool, it looks like an actual quote “machine”! @xavierartot, it is more than just printing from a database. The Math.random() is used in the api itself to get a random quote from their database - there is no need to randomize an api which already gets a random value… ---
**Author:** ![xavierartot](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/xavierartot/32/160720_2.png) [@xavierartot](https://forum.freecodecamp.org/u/xavierartot)\ **Post date:** [August 14, 2016, 2:40am UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/16 "2016-08-14T02:40:59Z")
Thanks I realize that but still, I don’t have any control with the database, the quote are not nice too. ---
**Author:** ![jvalonen](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/jvalonen/32/12460_2.png) [@jvalonen](https://forum.freecodecamp.org/u/jvalonen)\ **Post date:** [August 14, 2016, 3:08pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/17 "2016-08-14T15:08:53Z")
I find the design very unappealing. And why do I have to scroll down to see the quotes themselves? The animations work nicely, but when the aesthetics are so off they don’t help. Sorry if I seem harsh, I just believe that honest feedback is ultimately the most helpful. I partly agree with xavierartot on what he say about the quotes not being nice. I wouldn’t go that far, but do think that some consistency in who the quotes are from would be nice. ---
**Author:** ![ILM](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/ilm/32/363239_2.png) [@ILM](https://forum.freecodecamp.org/u/ILM)\ **Post date:** [June 1, 2021, 6:09pm UTC](https://forum.freecodecamp.org/t/review-my-random-quote-machine-project/26946/18 "2021-06-01T18:09:43Z")
Closed on June 1, 2021, 6:09pm UTC