Review on my product landing page

I just completed my third challenge aka. “product landing page”
I got in a lot of trouble with I was doing this challenge like I couldn’t set my nav bar properly and cant insert images and couldn’t resize it and that was so hectic :smiley: that’s is why I think that my page is lacking in appearance but anyway I’m gonna practice again.
but still I want reviews on it tell me what I did wrong :sweat_smile:
https://codepen.io/ridabatool/details/oNZgaZG

Your page looks good @ridzzali110. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • Mainly mentioning because everything the browser renders belongs in the body element. And there should only be one body…there are two in your code.
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
    • (The one for HTML misses things which is why I recommend W3C)
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • When hovering over the navbar white text on a light yellow background is hard to see. It’s a bad UX
2 Likes

thanks for the compliment I put these body tags to satisfy myself so that I cant have doubts that I’m doing anything wrong but I will apply your advise on next project :smiling_face_with_three_hearts:

Sorry…hit <enter> too soon. Please reread my post

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.