Seeking feedback on Random Quote Machine

Code Feedback
1

Looking for feedback on my Random Quote Machine. I tested in Firefox and Chromium.

I know it’s a simple project but any comments or criticisms are appreciated - especially help with best practices or anything that could have been done better. Thanks!

2

I really like it. Nice background choice. I would only change its attachment from fixed to background-attachment: scroll; so when you scroll down the page the quote text remains always with that background.

In scss to the buttons i would add:

  background: transparent;
  border: 2px solid skyblue;
  border-radius: 9999px;
  padding: 0.2em 0.8em;
  &:hover {
    color: #fff;
    background: skyblue;
  }

Good job. :+1:

3

I ended up going with the background-attachment: fixed; because I was dipping below the bottom of my background image while scrolling on small screens with background-attachment: scroll. Maybe there was a better way to fix that! But I thought it looked nice enough so stuck with it.

I like your button suggestion! Those look much better. After I get some more feed back I think I’ll steal that code.

Thanks for the feedback and the :+1:!

4