Step 58 Building skyline - Why switch vw to vh?

HTML-CSS
1

So, I completed this step, however it is not clear to my why should I change vw to vh for the border-bottom property. I can see some changes in the page, but it seems weird to switch. Can someone explain the logic?

Here the instruction for the step
Finally, on the border-bottom property of .bb2a, change the 1vw to 5vh and change the #000 color to your --building-color2 variable.

here what the code look like for the exercise

  border-bottom: 1vw solid #000;
  border-left: 5vw solid transparent;
  border-right: 5vw solid transparent;
2

please include a link to reference the step you’re in so we can read it easily.

3

Hey Buddy , can You please do tell us your problem more briefly.

So that we can help you in a good way !!

4

Because then the “height” of the roof won’t be driven by the viewport width, but its height.

If you think about what the borders do, it doesn’t really make sense to set their values based on the viewport width. It is much more likely you would want the viewport height to “drive” the roof height (i.e. smaller roof on shorter browser windows, larger/taller on taller windows).

Basically, to make the roof height scale with the height of the building.

2 Likes
5

ooh ok, I think I’m getting the sense of it now
thanks!

1 Like