# Survey Form Project - Feedback would be great!

**URL:** <https://forum.freecodecamp.org/t/survey-form-project-feedback-would-be-great/523383>\
**Category:** I Built This\
**Created:** [June 29, 2022, 11:09pm UTC](https://forum.freecodecamp.org/t/survey-form-project-feedback-would-be-great/523383 "2022-06-29T23:09:46Z")\
**Posts on this page:** 6\
**Page:** 1

<div class="post-metadata">

**Author:** ![casey\_shea05](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/casey_shea05/32/268530_2.png) [@casey\_shea05](https://forum.freecodecamp.org/u/casey_shea05)\
**Post date:** [June 29, 2022, 11:09pm UTC](https://forum.freecodecamp.org/t/survey-form-project-feedback-would-be-great/523383/1 "2022-06-29T23:09:46Z")

</div>

Hi there,

I just completed my first project, which was to build a survey form, and I’d love it if I could get some feedback on it! I had a lot of fun building this, albeit I spent around a 5 days doing it 😂

Although, I think one aspect I struggled with a lot was learning how to align things on the page with margins and padding, etc. I feel like as though my code could be structured better, or maybe there are some places where I could condense it down a bit? Let me know what you think!

> **[freeCodeCamp - Survey Form Challenge](https://codepen.io/casey_shea05/full/oNqgjEO)**
>
> ...

---

<div class="post-metadata">

**Author:** ![txt88](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/txt88/32/273550_2.png) [@txt88](https://forum.freecodecamp.org/u/txt88)\
**Post date:** [June 30, 2022, 4:13am UTC](https://forum.freecodecamp.org/t/survey-form-project-feedback-would-be-great/523383/2 "2022-06-30T04:13:12Z")

</div>

To me it looks pretty good, congratulations!

I resized the browser screen just to see the behaviour and again, you nailed it!  
Since you asked, I have three suggestions:

1. There is a lot of space above and below the green line, for sure you can make it smaller.
2. Inside the white area, right at the top, before the text in Mandarin(?) there is also a lot of space there.
3. The image with the dumplings seems to be a little bellow the image with the text.

Again, overall it looks excelent!

---

<div class="post-metadata">

**Author:** ![bbsmooth](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/bbsmooth/32/203556_2.png) [@bbsmooth](https://forum.freecodecamp.org/u/bbsmooth)\
**Post date:** [June 30, 2022, 4:57am UTC](https://forum.freecodecamp.org/t/survey-form-project-feedback-would-be-great/523383/3 "2022-06-30T04:57:22Z")

</div>

This is very nice. I have just a few accessibility issues to point out.

- You need to have a `label` for both the select list and the textarea. Right now you have the question for each of these in a `p`. Just turn that into a `label` and be sure to add a `for` attribute.
- For the radio button and check box groupings, you need to use a `legend` for the question instead of a `p`.
- All of the content should be in a `main` element. I would just change the “form-body” `div` to a `main`.
- The `h1` should have the `lang` attribute set to the appropriate [language code](https://www.tutorialspoint.com/html/language_iso_codes.htm).
- Technically, every element `id` should be unique, so you should give the `h2` a different `id` value so it’s not the same as the `h1`.

Again, very nice job.

---

<div class="post-metadata">

**Author:** ![casey\_shea05](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/casey_shea05/32/268530_2.png) [@casey\_shea05](https://forum.freecodecamp.org/u/casey_shea05)\
**Post date:** [June 30, 2022, 5:47pm UTC](https://forum.freecodecamp.org/t/survey-form-project-feedback-would-be-great/523383/4 "2022-06-30T17:47:18Z")

</div>

Hi, thank you so much taking the time to write out such a detailed response on where I can improve to make sure my code is compliant with the accessibility standards! I’ll definitely be making those changes as soon as I get the chance to!

---

<div class="post-metadata">

**Author:** ![casey\_shea05](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/casey_shea05/32/268530_2.png) [@casey\_shea05](https://forum.freecodecamp.org/u/casey_shea05)\
**Post date:** [June 30, 2022, 5:49pm UTC](https://forum.freecodecamp.org/t/survey-form-project-feedback-would-be-great/523383/5 "2022-06-30T17:49:52Z")

</div>

Hi there,

Yeah, I was wondering if I left too much blank space so it’s really useful to get a second opinion on it! 😂 Thank you so much for your suggestions, and I’ll be making changes accordingly when I get the chance to!

---

<div class="post-metadata">

**Author:** ![system](https://global.discourse-cdn.com/freecodecamp/original/3X/e/1/e1c433102e34b46dfaa3e15d13ab9a514b127078.svg) [@system](https://forum.freecodecamp.org/u/system)\
**Post date:** [December 30, 2022, 5:50am UTC](https://forum.freecodecamp.org/t/survey-form-project-feedback-would-be-great/523383/6 "2022-12-30T05:50:28Z")

</div>

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.
