Tests on Roman Numeral Converter are not doing what they should (I think)

JavaScript
1

I think that I am finished with the roman numerals project - the output seems always right - but the tests won’t let me through! The output is a string and in capitalized letters as requested… Can someone please help?

   **Your code so far**

function convertToRoman(num) {
  const romanFives = ["V","L","D"]
  const romanOnes = ["I","X","C","M"];
  var result = [];
  var separatedDigits = num.toString(10).split(''); //splits the num into an array of digits
  var numberOfDigits = separatedDigits.length
  for (var i=0;i<numberOfDigits;i++){
    var digit=separatedDigits.pop();
    if (digit==1){
      result.unshift(romanOnes[i])
    }
    if (digit==2){
      result.unshift(romanOnes[i]+romanOnes[i])
    }
    if (digit==3){
      result.unshift(romanOnes[i]+romanOnes[i]+romanOnes[i])
    }
    if (digit==4){
      result.unshift(romanOnes[i]+romanFives[i])
    }
    if (digit==5){
      result.unshift(romanFives[i])
    }
    if (digit==6){
      result.unshift(romanFives[i]+romanOnes[i])
    }
    if (digit==7){
      result.unshift(romanFives[i]+romanOnes[i]+romanOnes[i])
    }
    if (digit==8){
      result.unshift(romanFives[i]+romanOnes[i]+romanOnes[i]+romanOnes[i])
    }
    if (digit==9){
      result.unshift(romanOnes[i]+romanOnes[i+1])
    }


  }

  result=result.join("")
 return console.log(result);
}

convertToRoman(1576);

   **Your browser information:**

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.131 Safari/537.36

Challenge: Roman Numeral Converter

Link to the challenge:

2

console.log() prints out to console, but it returns undefined.

2 Likes
3

Oh my god, how did I miss that?! Thank you!

4

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.