This is my first project and i will appreciate if you give me your feedbacks

This is my first project and i will appreciate if you give me your feedbacks
0

#1

#2

Not bad!
Seriously! This is better then what alot of people do.

Was a little worried because of the tried and tested design but you made it work. It all flows together really nicely.

The code checks out too. No doubt in part due to bootstraps help. Speaking of code… I think the word your looking for is “quotes”. Not “saying” :wink:

If this is your first project, cant wait to see what you do next. Keep it up!

:+1:


#3

@hayuniForum Well done! I agree with @ItsRoyal that your project looks nice. Here are some things to think about if you want to make improvements and follow best practices:

For valid HTML, you’ll want to look at the Doctype and the Head and Body sections of FCC Beta. All HTML markup should have these elements.

You’re using a lot of presentation elements in your HTML (<p style="color:black"> for example). Most of these cases will be better as CSS. See Separation of Concerns to learn more.

Paste your HTML into this HTML validator so you can see some of the errors in your HTML. One of them is a major error regarding a missing alt attribute for your image. Alt attributes are really important for search engines and screen readers.

Your heading elements jump from <h1> to <h5>, so I’m guessing you did this to decrease font size. As you can see below, even though heading elements do have different default font sizes in browsers, they’re not really intended to be used that way (Source):

  • Heading information may be used by user agents, for example, to construct a table of contents for a document automatically.

  • Do not use lower levels to decrease heading font size: use the CSS font-size property instead.

  • Avoid skipping heading levels: always start from <h1>, next use <h2> and so on.

  • You should consider avoiding using <h1> more than once on a page. See “Defining sections” in Using HTML sections and outlines for more information.

Line 14 of your CSS should be changed from paddig:10px; to padding: 10px;. I found this by pasting your CSS into this CSS validator. Both the HTML validator above and this one have saved me from small errors like this many times.

Keep working hard and learning! Your work is off to a good start. :sunny:


#4

Thank you so much… i know i will learn a lot from you all. I appreciate it.


#5

I appreciate the feedback. i will definitely read the links a learn from them. Thank you.