Tribute Challenge Completed- Would Appreciate Any Criticism and Advice

Had a difficult time working out the colors so I gave up. But here it is: https://codepen.io/Freddy-Murefu/full/PwYbbWP
Feedback would be greatly appreciated.

2 Likes

Hi @freddymurefu

Here are a few points you may wish to consider:

  • include a title element within the head element
  • include an alt attribute with the img element
  • avoid nesting p elements within figcaption or ul elements
  • the #image + figcaption selector is causing a white tail
    image
  • the img element does not need a white background
  • the #image selector already has a display property value of block, so you do not need to apply it to the img element
  • combining the two selectors is causing the image to become off center
  • similar issue with h1 + p selector: text-align property is duplicated as h1 already have text centered, and it has no effect on the p elements
  • good use of fonts and semantic elements
  • I noticed a black edge on the left side of the image. To make it look even, you could add custom top, right and bottom borders to the image element.
  • to make the code easier to read, apply consistent indentation

Happy coding

1 Like

This is very helpful. Thank you very much.

1 Like