Tribute page - challenge completed

It’s been a month since I started freecodecamp and here’s my first project.

https://bhagatsingh.imfast.io/

1 Like

A solid effort. I’m not seeing any major violations. But that doesn’t mean I don’t have a few suggestions :slight_smile:

  • I would not text-align: center the content. A lot of people find that hard to read. Use left justification, it’s what most people expect.
  • Those <strong> phrases at the beginning of your paragraphs. To me those look like headers and should probably be coded as such. You can still make them inline as they are now.
  • You’re missing <p> tags around a few of the paragraphs.
  • I have mixed feelings about the h3 at the bottom of the page. Headers are more like labels, they shouldn’t really be actual content.
  • The h2 header says “A brief note on Bhagat Singh’s life:” and then below that are six paragraphs crammed with information. So I think that header title is a little misleading :slight_smile:
1 Like

Thanks for taking out time to review my project. I will make sure to implement all of your suggestions.

Page looks good @jaswindersbm. A couple of things;
Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).

  • The test script should be included, with all tests passing, when you submit your project.
  • You should be using external styling when creating your projects.
    • Having the style element inside the body element violates syntax rules.

Hello @jaswindersbm! I like your page and its appearance is attractive, but personally I think the paragraphs have a very high word density and it is difficult to read.
Other than this, the page is responsive and demonstrates HTML knowledge.
Congrats and keep coding.
May the Force be with you =).

Thank a lot for checking out my project.

Yes , my codepen submission had the script in it. This isn’t the actual submission. I just wanted to host the page somewhere different so I removed the script.