Tribute Page - Chris Hadfield

Project Feedback
#1

The link to my tribute page: https://codepen.io/timothy_chan/full/LYWGdXd

Thanks for taking the time to give feedback!

#2

Saw your project! Nicely done I feel. Contrast is well achieved. Short and sweet too.
Only I felt that the space between "Chris Hadfield is: " and the points - was a bit unnecessary (of course, it’s a matter of subjectivity :sweat_smile:).

#3

Welcome to the forums @timothy_chan. Your page looks good. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    • “wikipedia” is not accessible
#4

Thanks prajaktas! I changed from <p> to <div> so the space is smaller.

1 Like
#5

Thanks Roma! I fixed what you pointed out.

1 Like
#6

It looks good @timothy_chan. Nice job!

1 Like
#7

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.