I’m no stranger to coding (just finished a bootcamp in April). In between job hunting (and hope to find something soon), I’m keeping up with practicing. I started FCC I think last year - off and on working my way through.
My Tribute page- It’s kind of plain so to speak…I might spruce it up some more at some point.
Generally speaking, the page its ok but i would take a deeper look on how the page is looking on mobile. You have in there margins and text-indents that in my opinion are too high for a mobile version of the page.
Also, you should consider making your css code as DRY(Do not Repeat Yourself) as possible. Here what i mean:
You have this repeating css code for each of your days class:
with the exception of background-image that is different for each one.
So, why not making a general style and after make a class to only add your particular background-image to your html.
Something like:
The DRY part did cross my mind and that’s something I’ll fix; I wasn’t super sure because of the multiple different images for the
s but your comment makes sense.
I hadn’t gotten as far as refactoring it for mobile/tablet format as I’m not entirely used to doing that with HTML & CSS. I was pretty much playing around trying to get it all to look somewhat nice (and to pass the FCC tests) onscreen; a little hard to do when my screen resolution is not the ‘normal size’ and I forget to make sure my browsers are set at 100% and not 125-150%.
(I’m still thinking in React for responsive design for pages lol)
Thanks! I was just finishing up refactoring the timeline.
The rest I’ll work on. I tend to forget about that part as I don’t always use my mobile for web surfing (many times font is too small and zooming in is fun in moving the page back and forth to read
About to edit codepen and push to git for the refactor…