Tribute page - feedback appreciated

Code Feedback
1

Hello, everyone

I finished tribute page project recently. Would love to have some feedback.

Is there anything that you would have done differently? I especially have a hard time fitting image size and what unit (px, em? %?) I’m supposed to be using.

Thank you very much.

1 Like
2

This looks very good to me. I only have a few suggestions:

  • The black text on that green background does not quite have enough contrast to make it accessible. You will need to lighten up the background just a little. Technically, the contrast ratio must be at least 4.5:1 to be considered accessible. I use the WebAIM Contrast Checker to make sure I’m meeting minimum requirements.
  • The alt text on the images could possibly be a little more descriptive.
  • Don’t use the title attribute on the last image to convey additional information to the user. Not everyone will be able to see that information (for example, people using a keyboard to navigate your page) so you are unintentionally hiding that information from certain people. You could use a figure element and then in the figcaption you could display this information. Or you could just add it as a simple p element below the image. To be honest, the title attribute should almost never be used because it has a lot of accessibility issues. So I would just forget it even exists (except for the very few instances in which it is actually required, which I won’t go into now).
  • You are using a figure element for the first image, but you have the alt text and the caption text saying the same thing. If the alt text and caption text really should be the same then you can make the alt text empty (alt="") to hide it from assistive tech like screen readers since it would just be redundant information. But in this case, I don’t think they should be the same. The alt text should describe what she looks like, and the caption text can remain what it is.
1 Like
3

Hi @bbsmooth,

That’s a nifty website, will definitely run things through there next time.

The green background-color is definitely something that I didn’t put a lot of thought into. It just look decent enough on my screen but I sort of settle into it after reading some of the materials.

Thanks a lot for the feedback.

(the title was nostalgia on my part :sweat_smile: . There used to be a blog where the writers often write jokes/complain/etc. on the image, it only show when you hover on it. Now I know why they stopped doing it.)

1 Like
4

Is it XKCD by any chance?

5

Nope. I wasn’t aware XKCD did it, though I haven’t read much of it. It’s RockPaperShotgun.

6

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.