Tribute Page - Feedback - Audie Murphy

Hi guys,

I just finished my first page creating the tribute page, which was given to me as a task.

What do you think? What could I have done better, how do you like it?

Would love to read some feedback on my first created page!

Thank you freeCodeCamp your courses are great!!

Welcome to the forums @dandrew.schroeder. Your page looks good. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your projects.
    • Your page passes 8/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • The link to the font goes in the box labeled ‘Stuff for <head>’
  • Codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it, there’s a couple of minor errors to clean up.
      • After fixing one error, click analyze again. Keep going until it’s clean.
    • (The one for HTML misses things which is why I recommend W3C)
  • Review the lesson about giving meaningful text to links.
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
1 Like

Thanks for your feedback!

I will have a look into it and get the issues fixed, thank you!

1 Like

Everything listed in your post should be fixed now. Thank you for showing me the inbuilt features of CodePen; they’re gold! And I definitely have to take a closer look at applied accessibility.

Short question. I went a little too fast the last time, submitting the project with all its issues. Should I resubmit it?

Cheers!

Since you modified and corrected the pen you submitted, no, you do not need to resubmit.

1 Like