Hi @jwilkins.oboe, thanks for your feedback.
how can i fix the CSS errors, if you donât mind me asking.?
and what will be the recommended font-size for a smaller device?
Move the first curly brace to the right of the h1.
Second one is this
body {
font-family: https://fonts.google.com/specimen/Libre+Baskerville?sidebar.open=true&selection.family=Libre+Baskerville; }
This is an incorrect way to use imported google fonts. When you select a google font that you like then you can just follow the instructions to embed that font into your page.
thank you thank you! that is very helpful.
after i am done with fixing those issues how can i run test on my page ?i did not really understand the instructions.
i am sorry i am asking alot of questions but i am new to this and i am still learning.
Oh sorry, you should put it in the bottom of the page. It will still work if you place it at the top before main it is just better to get in the habit of placing your scripts at the bottom. When you get to the javascript section you will start to understand why that is. But here is a good article explaining why.
Your page looks good @rehamsalem89. Some things to revisit;
Codepen provides the boilerplate for you. It only expects the code youâd put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the âSettingsâ button, then HTML and add it into the âStuff for <head>â box.
Mentioning because you have elements out of order. Everything the browser renders belongs in the body element. You have code outside of a closing body tag and the head element should not appear within the body element.
Additionally, when using Google fonts, if using import that goes in the CSS section of codepen (not between the style element. If you link to the font that goes in the head section and it would not be between style elements it would be a link.
Make your page responsive. Remember, the R in RWD stands for Responsive.
On smaller screens there is a horizontal scrollbar because the nav falls out of the container.
As mentioned previously, run your HTML code through the W3C validator.
There are HTML coding errors you should be aware of and address.
Since copy/paste from codepen you can ignore the first warning and first two errors.
Although it is a minor occurrence in your page right now, never use view port units for font sizes. The user should always be in control of the text size on the page (that is, they should be able to manually increase the text size). Using view port units prevents them from doing this. Your job as a developer is to make sure your page is responsive to text size increases. If you donât know how to manually increase the text size, using Firefox, go to the âView->Zoomâ menu and activate âZoom Text Onlyâ. Then while holding down the Ctrl key scroll your middle mouse button to increase the text size. Currently, the text size on your page will not change using this method because all of the font-sizes are defined with vw units. This means the only way I can increase the text size is to widen my browser window. What if I have really bad eyesight and canât make my browser window wide enough?
On a side note, next time when asking for a review of your project youâll get more eyes on if you open the topic in âProject Feedbackâ.