Tribute Page Feedback - Celene Fraticelli

Project Feedback
#1

Aloha FreeCodeCampers!

I just finished working on my tribute page and was hoping for some feedback.

https://codepen.io/cfraticelli/pen/abBzEPw

(I failed the test asking for the tag to responsively resize and I think it’s because I built the page using flexbox before I looked at the user stories…whoops. That being said I think my img responsively resizes.)

1 Like
#2

Your page looks good @cfraticelli. Some things to revisit;

  • The test script should be included, with all tests passing, when you submit your projects.
    • Your page passes 9/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue. (Be sure and read more than just the first line of the failing message.)
      • There are a few ways to make the image responsive but FCC only wrote one test so they test for one way. You can follow the failing messages to make it responsive and restyle your page if/as needed. Or redo the page and use this page to showcase your work outside of FCC’s test suite.
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • For instance links to fonts go in the box labeled ‘Stuff for <head>’
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
    • (The one for HTML misses things which is why I recommend W3C)
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • Make your page responsive. Remember, the R in RWD stands for Responsive
    • There’s a horizontal scrollbar on smaller screens

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/br

1 Like