Tribute Page Feedback - FCC

Since I asked for feedback on my survey page I want feedback for an earlier project I did, the Tribute Page.
Here is my tribute page https://codepen.io/EdgeO/pen/YzWdyrg
I appreciate any tips for it to improve

Hey @EdgeO!

I think your page looks good.

A few things.

  • There are few errors in your html and css that need your attention. Run your code through the analyzers and w3 validator. https://validator.w3.org/

  • For id’s, you can not group multiple id’s together like you can for classes. Id’s can not have spaces.

<ul id="ul2 ul">

Hope that helps!

2 Likes

I fixed the double id’s and improved the responsive design.
Thanks for the help!

1 Like

Looks better. Good job with those changes.
There are still some errors in the html that need your attention.

2 Likes

I changed it by making the two lists look like one long list on mobile to make it look better.

1 Like

Your page looks good @EdgeO. Some things to revisit;

  • When using codepen, the link to the font(s) goes in the box labeled ‘Stuff for <head>’
  • Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links.
  • User’s are not seeing the page the way you want because you only link to a light font weight (300). The browser will try but it has nothing else to work with.
    • What you need to do when you link to mulish is select the light (300) or normal (400) but also select the bold (700) so that when you use the bold tag the font will actually be bold.

On a side note, it’s a probably a nit for now but with semantics there is a difference when someone is using a screen reader between bold and strong. Bold is when you want the font to be bold and strong provides emphasis on the part of the text that the tag surrounds.