Tribute page feedback - Irena Sendler

Project Feedback
#1

Hello! This is my first post so hi to all of you!
I have recently finished my first project and would appreciate any feedback. I really am not sure about many things (for example the usage of flex vs grid) and am under impression my HTML structure has too much divs.

Anyway, here is the link: https://codepen.io/karolinawojak/full/ymNYqB

Thanks!

1 Like
#2

You didn’t close all the <figure> tags.

Don’t use <figure> without a graphic or img.

You only have one actual figcaption the rest are list headings. Use a heading tag or at least a <p> you could style bold.

You have an unclosed block on a media query.

I like everything else nice style, good subject. Learned something new today.

#3

Hello, very good.

I need to improve my work a lot you give me a good vision for my exercises and projects.
Thank you!

#4

This is one of the better Tribute pages I have seen. Keep up the great work.

#5

Thank you very much for the feedback. I fixed the issues you wrote about. I’m glad you liked the subject :slight_smile:

#6

Thank you! I’m glad you like it.

1 Like
#7

Thank you, it means a lot.

#8