Tribute Page Feedback - Irena Sendlerowa

Code Feedback
1

Hey guys! I’ve just finished my first project on FFC and I would love to here your sincere feedback on it.
Thank you very much in advance!
Happy coding for everyone! =)

https://codepen.io/DianaMac/pen/vYXLXwY

1 Like
2

Hi @DianaMac!

Welcome to the forum!

I think your page looks good.

  • Keep the test suite in your project for submission.
    <script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>

  • You have a stray html tag at the end of the page that can be removed

  • There is an error in your img tag. The src attribute needs double quotes.

  • When I view the project on my phone the text is a little bit small.

Hope that helps!

1 Like
3

Thank you very very much!
I tried to fix the things you mentioned. I added a media querie to the css and I think it’s more responsive now. But I don’t know how to make it better! :grimacing:

Thank you!! :pray: :grin:

4

I think it looks better now.

Thanks for making those changes.

I think you are ready to move onto the next project.
Remember that your first projects don’t need to be perfect or super polished because you are just starting out. As you continue to build more then you will start to feel more comfortable to take more risks with style, animations, and even adding javascript when you learn that in the next section.

Keep up the good work.

1 Like
5

Thank you very much for all your kind words!! :pray: :blush:

I will move on to the next project.

Have a great day!

1 Like