Tribute page feedback (Terry Fox)

Hey guys, I just finished my tribute page and would love to get some feedback. Thanks!
Terry Fox Tribute Page

Welcome to the forums @jmiculob. Your page looks good. Some things to revisit;

  • Run your HTML code through the W3C validator.
    There are HTML syntax/coding errors you should be aware of and address.
    Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.” is not accessible

Don’t set the font size, especially not smaller only to then make it larger.
Browsers have a default font size and that should be what’s used.
If you want to make the font larger in other sections that’s okay.

1 Like

Thanks for the feedback! I removed the ‘fig-caption’ element and just replaced it with a ‘p’ element. I also changed where my ‘a’ element wrapped around to give the link more meaning and accessibility. In regards to the font size, should I just delete:

html {
font-size: 10px;

from CSS and just change the fonts in each section accordingly?

That’s okay too but as you progress, for semantics, it would have been better to leave the optional figcaption element and replace the outer div element with a figure element.

Very nice.

Yes. And nice job using rem for font sizes rather than pixels.

1 Like