Tribute Page Feedback - "Tribute"

Code Feedback
1

Hi All,
Just completed my tribute page about the song “Tribute” by Tenacious D. Any feedback or suggestions on how to improve the page would be greatly appreciated.
Thanks!

Tribute Page

1 Like
2

hey how did ypu submit it ?

3

Are you asking how I submitted my project to the challenge on the curriculum page?

4

i got it anyway thanks

5

Welcome to the forums @jam2767. Your page looks good. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • The link to the font goes in the box labeled ‘Stuff for <head>’
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
      • You have an element you didn’t close properly. And this </img> is not a valid HTML tag. The <img> element is self closing.
  • We’re not seeing your page the way you want us to. You call the ‘Roboto Mono’ font but neither link to it or import it. You may have it loaded on your box, most will not.
  • Side note, learn about the DRY (Don’t Repeat Yourself) principle. You call this font-family: 'Roboto Mono', monospace; five times in your CSS. You can put it in one place. Think/hint;
     body {

     }
  • Don’t use <br> to create space or force line breaks. That’s what CSS is for.

I don’t normally comment on someone’s code because it’s there own. Maybe try a universal reset and see if you like it. Starting on the first line in your CSS try the following and see if you like the results;

* {
  margin: 0;
  padding: 0;
}
2 Likes
6

Thank you @Roma for all of the comments! I think I’ve addressed everything you pointed out.

  • I’ve moved all elements into the settings 'Stuff for ’ box, including the link to the font

  • W3C validator now only gives the warning that I’m missing <head>, but I know that’s OK because it’s in the settings on Codepen.

  • font-family and color now only show up where they are unique. Thank you for pointing out DRY principle.

  • <br> is not being used anymore.

  • The reset looks much better, thank you for suggesting.

1 Like
7

Nice job cleaning things up @jam2767.
Because codepen provides the boilerplate you can also omit the doctype and html elements.

1 Like