Tribute Page for Ada Lovelace: feedback please

Code Feedback
1

Hi all,

This is the first page I have hand coded. Feedback appreciated!

Kellie

2

Hi ! :slight_smile:
That is a nice beginning!

Is it a choice not to have padding into your main?

CSS:

  • You can use background only instead of background-image, to do the gradient background:
    background: linear-gradient(100deg, #ccfff2, #00cc99);

  • As you saw on the CSS Basic course, why not using some CSS variables? For the font-family for example:

:root {
--font: 'Raleway', sans-serif;
}
p {
  font-family: var(--font);
  font-size: 25px;
}
ul {
  font-family: var(--font);
  font-size: 25px;
}

Have a nice day and Good learning!

3

Thanks, mangasource! There is no reason, other than I am still learning how to put all of this into play. I’ll definitely incorporate your suggestions.

Best,

Kellie

1 Like
4

Hi :slight_smile:
It’s great, keep it up!
Good learning !