Tribute Page for Bruce Lee

Code Feedback
1

Hi everyone :slight_smile:

I’ve finished coding a tribute page for Bruce Lee.

Bruce Lee Tribute Page

I’d love to hear your feedback, thanks!

2 Likes
2

@sitek94 I think your page looks great! Good work!

1 Like
3

Your page looks good @sitek94. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your projects.
    • Your page passes 8/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
1 Like
4

Thank you very much for the feedback, I really appreciate it!

I have to confess that I haven’t even run the tests… I was just crossing the tasks on the paper and absolutely forgot to run them before posting.

I fixed, everything now and got the green light from the test suite :smiley:

Bruce Lee Tribute Page - fixed

5

Looks good @sitek94. I noticed there is one test that still fails. Easy enough fix. Just change

#image {
  display: block;
  margin: 0 auto 1rem;
  width: 100%;
}

to

#image {
  display: block;
  margin: 0 auto 1rem;
  max-width: 100%;
}
1 Like
6

Well, I could swear that I fixed that before replying to you… maybe I didn’t save that, well it doesn’t matter know :smiley:

Everything is up and running now for sure, so once again, thanks for help!

1 Like
7

I like the design. It is very sleek.