Tribute page for Edgar Allan Poe - Please give me feedback :)

Tribute page for Edgar Allan Poe - Please give me feedback :)
0

#1

I have just started here and done the bootstrap and html/css/js. I have created a tribute page to Poe. Please let me know if it’s any good and if I could improve it.

Pen located here

Many thanks


#2

I like that you have a quotes section.

I did not see a navigation bar, which I think is one of the requirements of the exercise.

While I don’t personally mind the quotes next to the timeline, you will likely have to change this formatting, if you are going to have a menu item that links to the quotes.

I felt the the text for the timeline was either too fine or too small – but it just may be my monitor.

Overall, I think that you have done well.


#3

Hi
HTML Codepenlinter

  • The ‘alt’ attribute is required for elements.
 <img class="img-responsive center-block" src="https://c7.staticflickr.com/8/7217/7158127310_f81e7ef908_z.jpg" />
    </div>
  • Nesting list problem:
<ul>
        <li>1809</li> <-- here
        <ul>
          <li>Edgar Poe is born on January 19, in Boston.
</li>
          <li>Thomas Jefferson is President
</li>
          <li>Abraham Lincoln is born on February 12, in Kentucky
</li>
          <li>Charles Darwin is born on February 12, in England
</li>
        </ul>

MDN code example [0]:

<ul>
  <li>first item</li>
  <li>second item      <!-- Look, the closing </li> tag is not placed here! -->
    <ol>
      <li>second item first subitem</li>
      <li>second item second subitem</li>
      <li>second item third subitem</li>
    </ol>
  </li>                <!-- Here is the closing </li> tag -->
  <li>third item</li>
</ul>

Using “ol”:

  • first item
  • second item
    1. second item first subitem
    2. second item second subitem
    3. second item third subitem
  • third item

Using “ul”:

  • first item
  • second item
    • second item first subitem
    • second item second subitem
    • second item third subitem
  • third item

[0] https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ul

Cheers and happy coding :slight_smile:


#4

Hi guys

Thanks for your feedback. I have wrapped those

    tags as you suggest erretres and enlarged the time line text also.

    I also added the nav and some anchors.

    Thanks so much guys

    J